toggle quoted messageShow quoted text
Ping me when you create a new release, and if you can, send me a sha1 or sha256 hash (Make sure to tell me which). Or provide me with a link so I can go verify the hashes myself.
On Tue, Jan 2, 2018 at 2:52 PM, Tony Malykh <anton.malykh@...>
I have fixed all the changes you proposed. I haven't made a new
release yet though. IF that's OK, I'll be happy if you can publish
it on the official NVDA add-ons site.
On 1/1/2018 7:28 PM, derek riemer
We need you to put a GPL header on this file so that anyone
downloading it knows it complies with GPL (This is because
it's running in NVDA's GPL process).
Next, let us know when you are ready for this to go on the
addons site (if you want that which I assume you do).
Other tidbits, not needing changed to pass code review:
def isEmptyLine(self, s):
Did you know about speech.isBlank?
Why is there a random pass at the end of the file?
Derek Riemer: Improving the world one byte at a time!
- University of Colorado Boulder Department of computer science, 4th year undergraduate student.
- Accessibility enthusiast.
- Proud user of the NVDA screen reader.
- Open source enthusiast.