toggle quoted messageShow quoted text
For me, no need for the commit SHA hash, as I can pull in latest commits and copy the add-on file to the right location for you.
Also, a few things to note:
- File names: camel case, so it’ll look like “indentNav”. It is too late to change the build vars as we’ll run into problems.
- I highly recommend using tags and GitHub releases for stable builds.
- As for declaring your add-on as stable, it is really up to you to tell us.
From: email@example.com [mailto:firstname.lastname@example.org] On Behalf Of Tony Malykh
Sent: Friday, January 5, 2018 4:49 PM
Subject: Re: [nvda] New add-on - IndentNav
I just made a new release of IndentNav. Here are the details:
IndentNav v1.2 release:
Also in the future when I decide to make a new release, will I have to send you updated checksums?
On 1/3/2018 2:03 PM, derek riemer wrote:
Ping me when you create a new release, and if you can, send me a sha1 or sha256 hash (Make sure to tell me which). Or provide me with a link so I can go verify the hashes myself.
On Tue, Jan 2, 2018 at 2:52 PM, Tony Malykh <anton.malykh@...> wrote:
I have fixed all the changes you proposed. I haven't made a new release yet though. IF that's OK, I'll be happy if you can publish it on the official NVDA add-ons site.
On 1/1/2018 7:28 PM, derek riemer wrote:
We need you to put a GPL header on this file so that anyone downloading it knows it complies with GPL (This is because it's running in NVDA's GPL process).
Next, let us know when you are ready for this to go on the addons site (if you want that which I assume you do).
Other tidbits, not needing changed to pass code review:
def isEmptyLine(self, s):
Did you know about speech.isBlank?
Why is there a random pass at the end of the file?
On Mon, Jan 1, 2018 at 6:43 PM, Tony Malykh <anton.malykh@...> wrote:
I just wrote my first NVDA add-on:
It solves two problems:
1. In browsers you can jump to paragraphs with the same horizontal offset. For example, it can be useful to read first-level comments on web-pages that present a hierarchical trees of comments, like reddit. Now you can simply find the first comment and press NVDA+Alt+DownArrow to go to the next first-level comment.
2. While editing source code in many programming languages, it allows you to navigate by the indentation level. For example, you can move to previous/next lines with the same indentation level by pressing NVDA+Alt+Up or DownArrow. You can also jump to a parent line or to first child.
Please let me know if anyone finds it useful, or if you have any suggestions.
Derek Riemer: Improving the world one byte at a time!
· University of Colorado Boulder Department of computer science, 4th year undergraduate student.
· Accessibility enthusiast.
· Proud user of the NVDA screen reader.
· Open source enthusiast.