Re: NVDA add-ons resources differences?
José Manuel Delicado Alcolea
Before answering to the question about code review, I should explain what nvda-addons.org is and why it was created. This is the first time I participate on this list, so I don't know if another member of the NVDA.es group has already done it before.
One of the main goals of the spanish community is to collect all available add-ons around the world in a single directory, excluding illegal and malicious ones. We are aware that we won't achieve completely this goal, but we continue exploring several groups, GitHub profiles and repositories, websites created by other communities, etc. This brings many advantages to our users and developers. Repeated work is avoided, people knows about wonderful add-ons developed outside the community, and our developers have very good code samples that they can use as starting points. I could list even more advantages, but this message would become too long.
Maintaining the directory becomes harder as more add-ons are added. We have to watch the source repositories, websites and so on when available and notify the community of add-on updates. This is the reason we developed our first solution: https://github.com/nvda-es/advancedAddonFiles
Since the directory became machine-readable and exportable in JSON format, Héctor decided to create the "Tienda NVDA.es" add-on, translated as "NVDA.es store". Updates are available as soon as the download links are modified from the web interface, avoiding delays seen in the international community, which relies on other procedures. User accounts can be created for add-on authors, who can update download links for their NVDA add-ons, but can't register or delete add-ons from the database.
The nvda-addons.org website is built on top of this web application, and aims to share all we have achieved so far beyond the spanish community.
After this short introduction, It's time to talk about reviews. We take code reviews very seriously, specially since review process is optional in the international community. When an add-on author introduces their work in the spanish mailing list, we perform a deep review and provide suggestions. When corrections are applied, we upload it to nvda-addons.org and publish the add-on documentation translated to spanish on the nvda.es website.
If the add-on comes from outside, a light validation is performed. Only security issues and license / copyright are checked in this case.
On november 2021, we published a guide on how to review add-ons. We encourage you to take a look. Use the Google Translate combo box located inside the web page or the translator of your choice: https://nvda.es/documentacion/desarrollo/documentacion-de-la-comunidad-hispanohablante/guia-de-revision-de-complementos/
El 28/12/2021 a las 20:16, Rui Fontes escribió:
Yes, the last add-on I submitted was reviewed by NVDA.es...
José Manuel Delicado Alcolea