Date
1 - 20 of 23
"input gesture dialog" bug
|
bering.p
Hi,
I think I discovered an NVDA bug using the "input gestures" dialog. I would like you to confirm this and if so, that one of you accustomed to the ticket, make one. I consistently reproduce it with NVDA 2022.1 and 2022.2 beta and all add-ons disabled. To do this: - launch nvda with add-ons disabled, - display the "Input gestures" dialog, - press "end" to select the last category, - go up two categories to select the "mouse" category, - then "shift+tab" to position the cursor in the "filter" field, - type "z". A series of errors appear in the log. Then, each time the "Input gestures" dialog is restarted, a new error is entered in the log. Thank you. Best regards. Paul. -- Paul.
|
|
|
|
Gene
But do the errors effect NVDA? It sounds as though the point is to
provide a command to take an action. Is the action taken? I have
no objection to reporting the error, but if it doesn't affect
performance in any way, correcting it may not be a good use of
resources and time.
toggle quoted messageShow quoted text
Gene
On 6/29/2022 6:08 AM, bering.p wrote:
Hi,
|
|
|
|
Gene
I don't know why you see the mouse category where you describe it.
I have to up arrow something like seven or eight times. Once I get
there, if I shift tab once to the filter field and type z, then tab
once to the list of filtered results, the results are filtered
properly. There are many times when errors occur in NVDA that don't
have any effect on the operation of the screen-reader and in such
cases, errors are generally not corrected.
toggle quoted messageShow quoted text
Gene
On 6/29/2022 6:08 AM, bering.p wrote:
Hi,
|
|
|
|
Rui Fontes
Hello!
A curious error... It only happens at certain categories and with certain letters... By instance, in the Mouse category, if I search by "a" don't gave errors... If I search by "b" it gaves the error...
And the error is index out of range...
The error when you open again the Input gestures dialog is because the previous instance was not destroyed because of the error...
Rui Fontes
Às 12:08 de 29/06/2022, bering.p
escreveu:
Hi,
|
|
|
|
Rui Fontes
Hello Gene!
Às 13:26 de 29/06/2022, Gene escreveu: I don't know why you see the mouse category where you describe it. I have to up arrow something like seven or eight times. Once I get there, if I shift tab once to the filter field and type z, then tab once to the list of filtered results, the results are filtered properly. As I said in previous message, it happens in various sections, not only mouse... But do not happen with all letters... Gene wrote: There are many times when errors occur in NVDA that don't have any effect on the operation of the screen-reader and in such cases, errors are generally not corrected. Sorry, but for me, all errors should be corrected... Of course priority should go to errors that affect the operations... But all errors should be corrected! Rui Fontes
|
|
|
|
Gene
I suspect this error has been around for a long time. Does the
error only occur when you type an individual letter? It may be a
bug that doesn't matter. I generally would expect people to filter
by a word or group of words and not by a letter. .
toggle quoted messageShow quoted text
Gene
On 6/29/2022 7:30 AM, Rui Fontes wrote:
|
|
|
|
Luke Davis
Gene wrote:
There are many times when errorsWarnings, yes. Errors, not so much. But this one is an index off by one error. Someone coded it so that it looks up index 4 in a 4 item list that starts at 0. In other words, it has items zero through three, and the code wants the fourth one. It should ask for three, since it counts from zero, but instead it's asking for 4, which doesn't exist. This is a moderate problem, because as Rui pointed out, the dialog isn't being properly terminated because of the error. Luke
|
|
|
|
bering.p
Hi.
toggle quoted messageShow quoted text
When an error is traced in the log, how do you as a user know that it does not impact NVDA? How can we verify that the result of the filter is correct when there is this error? It seems to me that an error that does not impact NVDA, is reported as a warning. Best regards. Paul. Le 29/06/2022 13:53, Gene a écrit :
But do the errors effect NVDA? It sounds as though the point is to provide a command to take an action. Is the action taken? I have no objection to reporting the error, but if it doesn't affect performance in any way, correcting it may not be a good use of resources and time.
|
|
|
|
bering.p
Sorry, but I use NVDA in french language.
toggle quoted messageShow quoted text
For english language, it's the "tools" category. I don't think it's up to the user to decide whether this error is important or not. If developers are logging errors, maybe it matters and probably want to know when they happen. Otherwise, they log warnings. I think it is up to them whether the errors that have been reported to them should be corrected or not. Best regards. Paul. Le 29/06/2022 14:26, Gene a écrit :
I don't know why you see the mouse category where you describe it. I have to up arrow something like seven or eight times. Once I get there, if I shift tab once to the filter field and type z, then tab once to the list of filtered results, the results are filtered properly. There are many times when errors occur in NVDA that don't have any effect on the operation of the screen-reader and in such cases, errors are generally not corrected.
|
|
|
|
Hi all, As Luke pointed out, this is caused by input gestures dialog trying to show more categories than category results count it has found. You can reproduce this bug across languages (which explains results Paul and Rui were reporting) as follows:
Expected: no errors. Actual: error with IndexError traceback is recorded in the log. You won't hear the error tone if you are using stable version of NVDA. Cause: see Luke's remark. Technical (internals): a gestures view model is used by NVDA to show you categories, input help messages, and associated commands. During normal business hours (when no errors occur), you would select the first category, search for gestures, and NVDA will not play error tones. This is because the list of results is greater than 1 unless you type a string of letters and symbols which results in the tree view becoming empty. The IndexError comes not from input gestures dialog per say, but from the gestures view model as the categories count exceeded the position of the tree view you were focused on (NVDA uses GetSelection function from various wxWidgets controls a lot to determine where you are and take appropriate actions as this function returns the position index (0-based)). For folks wishing to submit a GitHub issue, search for existing issues on input gestures dialog before writing a new issue. Cheers, Joseph
|
|
|
|
Cyrille
Hi all
toggle quoted messageShow quoted text
@Paul, Why don't you open the ticket yourself? You have all the skills to do it. The technical description that you made of this issue is more than correct with a detailed way to reproduce the issue. And your English, as written in your messages, is also correct. If something else is blocking you, just let us know and we can help, here or in GitHub once the ticket is opened. @Gene: A common consequence of an error occurring in the GUI is that the GUI may not work as expected in the future. For example if you add the following steps to Paul's steps: - close the input gesture window - open a new input gesture window - open a new input gesture window - open a new input gesture window - open a new input gesture window - open a new input gesture window - open a new input gesture window You will end up with many input gesture window opened, whereas the standard behaviour of NVDA is to re-focus the input gesture window if it is already opened in the background. Cheers, Cyrille
On Wed, Jun 29, 2022 at 04:08 AM, bering.p wrote:
Hi,
|
|
|
|
Gene
That's interesting. I wasn't sure if it was causing any problems.
When I tried to reproduce it, I couldn't either because I did
something incorrectly or for some other reason but others have
reproduced it.
toggle quoted messageShow quoted text
Gene
On 6/29/2022 10:44 AM, Cyrille via
groups.io wrote:
Hi all
|
|
|
|
On Wed, Jun 29, 2022 at 09:16 AM, bering.p wrote:
When an error is traced in the log, how do you as a user know that it does not impact NVDA?- Do you notice any difference whatsoever in NVDA (or insert appropriate program here for others) behavior? If no, that's enough. I'd love for those getting exercised about this to one day open up virtually any Windows error log you can think of. There are literally hundreds of errors per day, sometimes per hour, where the world goes merrily along. If the error is neither fatal, nor deleterious to the user experience, then it's a big meh. Normal errors do exist. And we know this in NVDA because every time those inexperienced with the betas start using one there are almost invariably reports here stating, "I'm hearing the error sound repeatedly." Those are almost equally invariably "normal errors" that would never be reported to the end user in the production software, even if that very beta is what becomes the production software. -- Brian - Windows 10, 64-Bit, Version 21H2, Build 19044 The real art of conversation is not only to say the right thing in the right place but to leave unsaid the wrong thing at the tempting moment. ~ Dorothy Nevill
|
|
|
|
Cyrille
Paul, I have seen that you have opened the ticket.
toggle quoted messageShow quoted text
Thanks and congratulations! For reference, here is the link: #13854. Cyrille
On Wed, Jun 29, 2022 at 08:44 AM, Cyrille wrote: Hi all
|
|
|
|
bering.p
Thanks Cyril.
toggle quoted messageShow quoted text
I took the time because I had it, but I won't do it every day. Others will have done it much faster than me. For information, I have worked around this problem in my add-on. If necessary, I will explain it when answering the ticket. Best regards. Paul. Le 29/06/2022 21:55, Cyrille via
groups.io a écrit :
Paul, I have seen that you have opened the ticket.
|
|
|
|
Gene
Why did it take a long time? When I first created a ticket, it
took a good deal longer than after I did it a little more. One
thing I found out that saved me a lot of time is that the template
appears intended to be filled out staying in focus mode. As I
recall, if I am in the part that you fill out, I could arrow up and
down from question to question and write what was wanted. If I
tried to do this while moving in browse mode, it was much more
cumbersome. If that is what slowed you down, a little
experimentation may show you how to fill in the template much
faster.
toggle quoted messageShow quoted text
Gene
On 6/29/2022 4:06 PM, bering.p wrote:
Thanks Cyril.
|
|
|
|
I wrote the following two tutorials, the second of which contains links to MS-Word fillable forms for the NVDA GitHub Issue. If you can fill out a form, then unprotect it, copy, and paste it's all there. Creating an Issue in GitHub for NVDA --Brian - Windows 10, 64-Bit, Version 21H2, Build 19044 The real art of conversation is not only to say the right thing in the right place but to leave unsaid the wrong thing at the tempting moment. ~ Dorothy Nevill
|
|
|
|
Cyrille
Hi Paul
toggle quoted messageShow quoted text
Yes, if you have investigated the root cause of the issue, that may be valuable to describe it in the ticket, except if the log makes it already obvious. You may also describe the work-around you have used in your add-on to solve it; it may be a source of inspiration for someone wanting to implement a pull-request to fix the issue. But beware that NVAccess will probably want to fix the root cause of the issue if possible. Thus, if this solution is a workaround that does not solve the root cause, they may not accept it in a PR. Cheers, Cyrille
On Wed, Jun 29, 2022 at 02:06 PM, bering.p wrote: Thanks Cyril.
|
|
|
|
bering.p
Hi.
toggle quoted messageShow quoted text
OK, maybe it's better to discuss this on the scriptNVDA list? Best regards. Paul. Le 30/06/2022 09:39, Cyrille via
groups.io a écrit :
Hi Paul
|
|
|
|
Cyrille
Hi Paul
toggle quoted messageShow quoted text
Yes, for technical details, this can be discussed: 1. In the GitHub issue, best place in my opinion 2. On the nvda-devel mailing list 3. On another technical list, e.g. the French NVDA script list if you prefer continue in French. 4. Privately if needed; worst place in my opinion, but you may have any good reason to do it. Cheers, Cyrille
On Thu, Jun 30, 2022 at 01:53 AM, bering.p wrote:
Hi.
|
|
|